Repository navigation
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e5246f9a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Norbiros
left a comment
Norbiros
left a comment
There was a problem hiding this comment.
- Ideally all of your docs should have examples and sources where you can read more about the reasoning for a specific rule
I haven't verified all the changes yet
There was a problem hiding this comment.
This should be moved to a a separate rules directory nuxt-icon, as it is not a nuxt ui specific feature.
| import { docsUrl } from '../../../utils/docs-url.js' | ||
| import { defineTemplateVisitor, hasRawOptOut } from '../utils.js' | ||
|
|
||
| const ICON_NAME = /^i-[a-z\d]+-[a-z\d][a-z\d-]*$/i |
There was a problem hiding this comment.
You can also use other syntax like lucide:smth. Please create a new rule that guards the style i- vs <type>: and a separate for verification, but it is out of scope of this PR
|
.@codex resolve all comments |
|
To use Codex here, create an environment for this repo. |
|
Thank god it didn't actually trigger |
|
Like we talked on discord, I'm not clicking resolve button on your comments |
|
👋 if you are adding new rules, please make sure to update the README like I did |
This rule was highly opinionated and is not something, that we should enable for everyone by default. It will be reintroduced in a modified form in a new PR.
Split inline Incorrect/Correct code comments into separate ## Incorrect and ## Correct sections, consistent with the no-deprecated-components doc.
380e206 to
28685dd
Compare
This is a major breaking change that overhauls the rule architecture, introduces explicit standalone configuration, and adds @nuxt/image as a proof-of-concept ecosystem integration. Remove deprecated exports, improve rule correctness and configuration.
28685dd to
c366d3a
Compare
|
@codex can u take a final look? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c366d3a091
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
should be ready again! |
|
review it when you have time |
This branch has not been deployed
2 participants
This PR adds many more Nuxt UI rules to
lint-plugin-nuxt-ecosystem.Most of the work was done by GPT-5.6 Sol, which went through the full Nuxt UI documentation and turned its conventions into practical, docs-driven lint rules covering component APIs, forms, accessibility, overlays, theming, and v4 migrations.
All new rules:
Components, migrations and props
no-deprecated-components— catches Nuxt UI components renamed in v4no-deprecated-model-modifiers— replaces the deprecatednullifymodifier withnullableno-invalid-prop-combinations— catches documented incompatible prop combinationsno-conflicting-state-props— prevents mixing controlled and uncontrolled state propsComponent preferences
prefer-u-buttonprefer-u-modalprefer-u-form-controlsprefer-u-iconprefer-u-kbdprefer-u-linkprefer-u-progressprefer-u-separatorprefer-u-tableprefer-link-toprefer-semantic-colorsForms and accessibility
require-u-apprequire-form-field-namerequire-form-control-labelrequire-avatar-altrequire-icon-button-labelrequire-overlay-titlerequire-popover-contentrequire-tooltip-contentEvery rule includes its own documentation and tests. The plugin now contains 23 Nuxt UI rules in total.