Repository navigation
Add custom SuperPoint EdgeDrawing extractor - #1
Merged
Merged
Conversation
Author
|
still testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
custom_superpoint.pyimplementingSuperPointWithED, a subclass ofSuperPointthat acceptsconfiganded_config.run_edgedrawingwhich runs OpenCV EdgeDrawing (cv2.ximgproc) on a grayscale image and returns unique line endpoints as(N, 2)points.forwardto obtainpred = self.net(image), extract standard SuperPoint keypoints (with NMS and top-k filtering), obtain ED keypoints, merge them according toed_conf['mode'](superpoint,edgedrawing,combined), and sample descriptors and scores withsample_descriptors.Testing
custom_superpoint.pywas added and committed without running test suites.Codex Task