Repository navigation
Firefin 0.2.5: sign-in, playback session and browsing fixes - #12
Merged
Merged
Conversation
Transport: - Add ISRG Root X1 next to the platform anchors for Jellyfin REST, media and snapshot clients; Android 5.1 lacks it. Validation is unchanged. - Fail a media read after 30 s without data; calls stay unbounded. - Clear favorite and watched marks with DELETE on the item resource instead of POST .../Delete. - Localize user-facing transport errors. Sign-in: - Classify failures by exception type; rejected credentials are no longer reported as an expired session. - Suggest http:// after a TLS failure on an address without scheme and confirm every cleartext sign-in; permit cleartext on Android 9+. - Revoke the token on sign-out and keep address and user name. Playback: - Finish the session once on natural end, fatal error, source change and teardown; offer retry with a new session after an error. - Choose subtitles from the server list during direct play as well. - Keep the screen on only while playback is wanted. Browsing: - Page container children past 60 entries, driven by D-pad focus. - Show episode numbers and a Continue button for series. - Hide library types without a native player; load home rows concurrently; show the overview for recently added items. - Show current values in settings; localize library sort names. Tests: PageCursorTest, PlaybackSessionTrackerTest, LoginErrorsTest, transport TLS/timeout cases, client route and paging cases, and an API 22 instrumented sign-in/mark/page/sign-out flow against a fixture server.
- README: installation by sideloading (Downloader or ADB), checksum check, sign-in address formats, troubleshooting, corrected device table, spelling and screenshot descriptions, current releases link. - CHANGELOG, BUILDING, COMPATIBILITY, SECURITY, technical overview and third-party notices: 0.2.5 changes and evidence, published 0.2.4 release, TLS anchor, cleartext confirmation and media read timeout. - Migration ledger: product-level scope and checklist without copied task rows or review-round labels; evidence, SHAs and open items preserved. - Issue and pull request templates describe Firefin on Fire TV devices, use existing labels and link to the installation help. - verify-native-apk.py: explicit checks that also hold under python -O. - FIRETV32-VERIFICATION.txt: placeholders replaced by "not recorded". - .gitattributes: exclude the legacy Flutter tree from language stats.
After the deliberate read timeout OkHttp marks the route as failed. On hosts where localhost also resolves to ::1 the follow-up request tried that address first and failed to connect, so the test now uses 127.0.0.1 and asserts the read timeout explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Firefin 0.2.5: fixes for sign-in, playback sessions and browsing in the native app, plus refreshed documentation and templates. Version
0.2.5-firefin/3001005; no release is created by this change.Changes
Native app
DELETEon the item resource.http://needs confirmation and works on Android 9+.WAKE_LOCKremoved.Repository
.gitattributeskeeps the legacy Flutter tree out of language statistics.verify-native-apk.pyuses explicit checks that also hold underpython -O.Area
app/)lib/,packages/,android/)Testing
:app:testDebugUnitTest83 passed, 0 failedassembleDebugandassembleReleasepass; APK verifier passes for both APKs:app:connectedDebugAndroidTest2 passed (login screen; sign-in over HTTP, favorite set/clear, paging through 125 episodes, sign-out and prefilled sign-in against a local fixture server); sign-in error and cleartext dialog checked manuallyChecklist