Repository navigation
feat!: rename bundle to youtrust/zdd-message-bundle - #51
Merged
Merged
Conversation
Following the GitHub organisation rename from Yousign to Youtrust, move the bundle to the youtrust vendor and the Youtrust\ZddMessageBundle namespace, and rename the console commands to youtrust:zdd-message:*. The legacy yousign:zdd-message:* names are kept as deprecated command aliases so consumer CI pipelines keep working across the upgrade. A functional test covers their resolution. They are scheduled for removal in v5.0.0. Two things needed care beyond the mechanical rename: the serialized fixture in ValidateZddMessageCommandTest carries PHP length prefixes that shift with the longer FQCN, and the expected console tables are padded to the widest cell, which is that same FQCN. BREAKING CHANGE: the package is now youtrust/zdd-message-bundle and exposes the Youtrust\ZddMessageBundle namespace. Consumers must update their composer requirement, their PHP imports, config/bundles.php, the messenger serializer service and any ZddMessageConfigInterface or CustomMessageGeneratorInterface implementation. Released as v4.0.0; yousign/zdd-message-bundle v3 is abandoned. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Clean break, consistent with the decision to give the yousign-vendored package no further release of any kind: v4.0.0 exposes youtrust:zdd-message:* only. Removes the deprecated aliases and the functional test covering them. BREAKING CHANGE: yousign:zdd-message:generate|validate|debug no longer exist. Callers, typically CI pipelines, must switch to youtrust:zdd-message:*. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
B-Galati
approved these changes
Aug 19, 2026
Nothing in the source or in the dependency graph needs PHP 8.4. The runtime requirement is symfony/console ^7.4|^8.0, and 7.4 runs from PHP 8.2 up, so the 8.4 floor was excluding users for no technical reason. Verified on real interpreters: the suite passes on 8.2, 8.3 and 8.4. 8.3 is the floor because 8.2 leaves active security support at the end of 2026. The CI matrix gains an 8.3 row. The coding-standards and PHPStan jobs stay pinned to 8.4. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The company behind this bundle is now Youtrust. This moves the package, its namespace and its console commands accordingly, and realigns the PHP requirement with what the code actually needs.
What changes
yousign/zdd-message-bundleyoutrust/zdd-message-bundleYousign\ZddMessageBundle\Youtrust\ZddMessageBundle\yousign:zdd-message:*youtrust:zdd-message:*^8.4^8.3YousignYoutrustClean break on the command names
No alias is kept for
yousign:zdd-message:generate|validate|debug— they are gone in v4.0.0.Worth knowing when you upgrade: these commands are typically invoked from CI pipelines rather than from PHP, so this break surfaces at run time in a job, not at autoload time like the namespace change. Update your pipelines as part of the upgrade. The README calls this out explicitly.
yousign/zdd-message-bundlewill be marked abandoned on Packagist, pointing at the new name. It gets no further release of any kind, security fixes included.Lowering the PHP floor from 8.4 to 8.3
The 8.4 requirement was excluding users for no technical reason:
symfony/console: ^7.4|^8.0, and Symfony 7.4 runs from PHP 8.2 up. On PHP 8.3 the union simply resolves to 7.4 instead of 8.0.8.3 rather than 8.2 because PHP 8.2 leaves security support on 31 Dec 2026, so it would be an EOL floor within months.
The CI matrix gains an 8.3 row. Coding standards and PHPStan stay pinned to 8.4.
Two traps worth flagging for review
Both are why the rename is not a pure
sed, and both are covered by the suite:ValidateZddMessageCommandTestcarries a hand-written serialized payload with length prefixes.Yousign→Youtrustis one character longer, soO:65:→O:66:ands:74:→s:75:.On the first point: that fixture is worth a follow-up regardless of this PR. Its length prefixes are hand-maintained, and its private-property mangling uses spaces where PHP writes NUL bytes — so it is a corrupt payload rather than the previous-version payload its method name suggests, and the "Syntax error" the test asserts comes from
$contentnever being initialised. Building it withsprintfandstrlenwould remove the magic numbers; making it a genuine previous-version payload would change what the test asserts. Out of scope here.Verification
Plus the suite run on real 8.2 / 8.3 / 8.4 interpreters, each with its own dependency resolution.
Release plan, after merge
v4.0.0.youtrust/zdd-message-bundlepackage is created.v3.4.0on the old package carrying theabandonedflag, and set Abandon on its Packagist page.maindeclares the new package name, Packagist can no longer crawl a matchingcomposer.jsonfor the old package.🤖 Generated with Claude Code