Reinstate get/set SEO data abilities - #23526
Draft
leonidasmi wants to merge 1 commit into
Draft
Conversation
Coverage Report for CI Build 2146Coverage increased (+0.2%) to 55.234%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Declaration of the abilities
The GET SEO data ability
Note for testers:
Throughout the testing process, to perform GET requests do the following:
http://YOUR-BLOG-URL/wp-json/wp-abilities/v1/abilities; make sure to adapt thepathToTestvalue accordingly to what you're testinghttp://example.com/wp-json/wp-abilities/v1/abilitiesendpoint and confirm that you see theyoast-seo/get-post-seo-dataability we added and that it looks like this:The SET SEO data ability
http://example.com/wp-json/wp-abilities/v1/abilitiesendpoint and confirm that you see theyoast-seo/update-post-seo-dataability we added and that it looks like this:seo_title,meta_description,open_graph_title,twitter_title,open_graph_descriptionandtwitter_descriptionin the input schema, unless you have Premium active tooseo_title,meta_description,open_graph_title,twitter_title,open_graph_descriptionin the input schema nowfocus_keyphrasein the input schema, regardless whether you have Premium enabled or notadd_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );filter) and confirm that you can't find the above abilitiesUsage of the new abilities
Using the REST API
Using our `getting SEO data` ability
Using our `setting SEO data` ability
seo_title,meta_description,open_graph_title,twitter_title,open_graph_descriptionandtwitter_descriptionandfocus_keyphrase, you will get a400 - ability_invalid_inputerror codeseo_title,meta_description,open_graph_title,twitter_title,open_graph_descriptionandtwitter_description, now works like seamlessly. Not forfocus_keyphrasethough, because this is not editable at all now.Using an AI agent
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #