Skip to content

macOS: Put kvm debug messages behind compile option - #403

Open
PTR-inc wants to merge 1 commit into
Ylianst:masterfrom
PTR-inc:mac-kvm-debug
Open

macOS: Put kvm debug messages behind compile option#403
PTR-inc wants to merge 1 commit into
Ylianst:masterfrom
PTR-inc:mac-kvm-debug

Conversation

@PTR-inc

@PTR-inc PTR-inc commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Also seen through the testing of the mac agent via terminal start.

As soon as a desktop session started, the console was flooded with dev debug messages. Put the already commented 'KvmDebugLog()' function in behind KVMDEBUGENABLED (enable through KVMDEBUG=1 in the make command) and replaced the debug messages with the the KvmDebugLog().
Default is off, so no more flooding.

The ...loop messages were send per frame, that were many

Example:
About to read from IPC Socket
...Enter for loop
Read 10 bytes from IPC-xx-Socket
enter while
exited while
About to read from IPC Socket
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • 🧠 I used LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🛠️ I have self-reviewed my code and self-tested it against a MeshCentral server to ensure it works as expected.
  • 🖥️ My change compiles on every platform it affects (Windows / Linux / macOS / FreeBSD), and I have considered
    the impact on platforms and architectures I could not test.
  • 📦 If I changed JavaScript modules under modules/, I re-embedded them so the compiled-in copies in
    microscript/ILibDuktape_Polyfills.c match (the agent runs the embedded copies, not the files on disk).
  • 🤖 I ran the agent self-test where appropriate (see "Self Test" in readme.md).
  • 📄 Documentation updates are included (if applicable), e.g. the .msh options table in readme.md.
  • 🧰 Updates to vendored dependencies (OpenSSL, zlib, ...) are listed and explained.
  • ⚠️ CI passes and is green (Windows / Linux / macOS / FreeBSD builds and CodeQL).

Testing

Tested on macos arm64/x64

As soon as a desktop session started, the console was flooded with dev debug messages. Put the already commented 'KvmDebugLog()' function in behind KVMDEBUGENABLED (enable through KVMDEBUG=1 in the make command) and replaced the debug messages with the the KvmDebugLog().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant