macOS: Put kvm debug messages behind compile option - #403
Open
PTR-inc wants to merge 1 commit into
Open
Conversation
As soon as a desktop session started, the console was flooded with dev debug messages. Put the already commented 'KvmDebugLog()' function in behind KVMDEBUGENABLED (enable through KVMDEBUG=1 in the make command) and replaced the debug messages with the the KvmDebugLog().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also seen through the testing of the mac agent via terminal start.
As soon as a desktop session started, the console was flooded with dev debug messages. Put the already commented 'KvmDebugLog()' function in behind KVMDEBUGENABLED (enable through KVMDEBUG=1 in the make command) and replaced the debug messages with the the KvmDebugLog().
Default is off, so no more flooding.
The ...loop messages were send per frame, that were many
Example:
About to read from IPC Socket
...Enter for loop
Read 10 bytes from IPC-xx-Socket
enter while
exited while
About to read from IPC Socket
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
...exit for loop
...Enter for loop
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
the impact on platforms and architectures I could not test.
modules/, I re-embedded them so the compiled-in copies inmicroscript/ILibDuktape_Polyfills.cmatch (the agent runs the embedded copies, not the files on disk)..mshoptions table in readme.md.Testing
Tested on macos arm64/x64