Repository navigation
Validate typed analysis responses before saving file evidence - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A syntactically valid but empty, missing-field, or wrong-type model answer could previously become file evidence with default values. Every file-analysis prompt now validates a typed response inside the provider retry loop; exhausted retries persist an explicit failure without AI evidence or evidence-backed proposals.
_listfields cannot bypass the contract._listunwrapping to LooseDict and bump analysis cache/provenance to v4 so prior unchecked cached results cannot be restored.Validation: 507 Python tests passed, one Windows-specific skip; all six Node UI state checks and CLI smoke passed. Independent Astra review reproduced the contract bypasses and verified their fixes. The optional legacy Gemini SDK emits a deprecation warning. Contract and parser policy are documented in docs/ANALYSIS_RESPONSE_CONTRACT.md.
Implements follow-up PR 1 from #7. This validates response structure; model naming accuracy, consuming-app compatibility and physical 100–500 GB qualification remain separate roadmap gates.