Repository navigation
Activity generation and document creation bugfix - #87
Merged
Merged
Conversation
Collaborator
|
After examining the code, while it should be fine to merge given it doesn't have any noticeable conflicts, I was confused as to how exactly we can test these changes. I'd like to know prior to giving the green light. |
Collaborator
Author
|
Testing the scheduler may be a bit challenging other than editing the time locally when running the code, since it is scheduled to execute the task at midnight, but the code being executed functioned as expected and can most likely be isolated for testing. Regarding the Activity document creation, I checked the Activities collection manually for correct creation, but we will most likely have to utilize a separate testing database or collection for unit tests. |
Collaborator
Collaborator
|
Alright, everything seems good to me. Go ahead and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Scheduler added to refresh activities routinely
Fixed bug with mongoose model during activity document creation at the time of user signup