Skip to content

Activity generation and document creation bugfix - #87

Merged
yubrandon merged 6 commits into
mainfrom
activities-backend
Oct 31, 2025
Merged

yubrandon merged 6 commits into
mainfrom
activities-backend

Conversation

@yubrandon

Copy link
Copy Markdown
Collaborator

Scheduler added to refresh activities routinely
Fixed bug with mongoose model during activity document creation at the time of user signup

@yubrandon yubrandon changed the title Activity generation and document creation Activity generation and document creation bugfix Oct 13, 2025
@DeMentidDev

Copy link
Copy Markdown
Collaborator

After examining the code, while it should be fine to merge given it doesn't have any noticeable conflicts, I was confused as to how exactly we can test these changes. I'd like to know prior to giving the green light.

@yubrandon

yubrandon commented Oct 16, 2025 •

Copy link
Copy Markdown
Collaborator Author

Testing the scheduler may be a bit challenging other than editing the time locally when running the code, since it is scheduled to execute the task at midnight, but the code being executed functioned as expected and can most likely be isolated for testing. Regarding the Activity document creation, I checked the Activities collection manually for correct creation, but we will most likely have to utilize a separate testing database or collection for unit tests.

@DeMentidDev

DeMentidDev commented Oct 27, 2025 •

Copy link
Copy Markdown
Collaborator

Upon testing your updates to the branch, I've run into the following errors on startup:
image

@DeMentidDev

Copy link
Copy Markdown
Collaborator

Alright, everything seems good to me. Go ahead and merge!

@yubrandon
yubrandon merged commit 5a3a564 into main Oct 31, 2025
1 check passed
@F-Hejazi
F-Hejazi deleted the activities-backend branch December 24, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants