Skip to content

fix(middlewareNode): bump nodemailer 6.7.8 -> 10.0.1 (Issue 4) - #242

Open
Deepesh-Katudia wants to merge 1 commit into
chore/deps-middleware-axiosfrom
chore/deps-middleware-nodemailer
Open

Deepesh-Katudia wants to merge 1 commit into
chore/deps-middleware-axiosfrom
chore/deps-middleware-nodemailer

Conversation

@Deepesh-Katudia

@Deepesh-Katudia Deepesh-Katudia commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Bump nodemailer 6.7.8 -> 10.0.1 in middlewareNode, isolated in its own PR so it can be reviewed and reverted on its own.

Part of a stacked series. Merge in order: audit-fix -> axios -> nodemailer -> googleapis -> uuid -> node-nlp. Each PR targets the previous branch, so its diff shows only its own bump; After merging each one, click "Delete branch" (this repo does not auto-delete merged branches). That makes GitHub retarget the next PR to main and run CI on it; if the branch is not deleted, the next PR must be retargeted to main by hand before merging, or it will merge into a dead branch. (3/6, stacked on #241)

Type of Change

  • New feature
  • Bug fix
  • Refactor
  • Documentation update
  • Style/UI update
  • Performance improvement
  • Other (please specify): dependency / security update (Issue 4)

Key Changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed: plain node -e "require(...)" of the package (catches CommonJS/ESM breakage that Jest mocks can hide)
  • All tests pass: 22/22 suites, 264/264 tests after clean npm ci

Bugs Fixed (if applicable)

  • npm audit after this PR: 6 findings (0 critical, 3 high)

TODO (Follow-up Work)

Additional Notes

Version vetted by @THRISHMA2424 on dependancyFix; regenerated fresh off current main.

Breaking major bump, isolated so it can be reviewed and reverted on its own. Supersedes Dependabot #156 and #227 (the latter only reaches 9.1.1). Test suite passes after the bump.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The upgrade introduces a Node.js runtime requirement shift (nodemailer now requires Node >=20) that should be explicitly enforced in the package metadata to avoid deploy/runtime mismatches.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR upgrades nodemailer in the middlewareNode package to the 10.x line as part of a stacked dependency/security update series, updating both the declared dependency range and the lockfile resolution.

Changes:

  • Bump middlewareNode’s nodemailer dependency from ^6.7.8 to ^10.0.1.
  • Regenerate middlewareNode/package-lock.json so nodemailer resolves to a 10.x release and updates its recorded engine requirements.
File summaries
File Description
middlewareNode/package.json Updates the nodemailer dependency range to ^10.0.1.
middlewareNode/package-lock.json Updates the lockfile to the resolved nodemailer 10.x package and its metadata (including Node engine requirement).
Review details

Files not reviewed (1)

  • middlewareNode/package-lock.json: Generated file
  • Files reviewed: 1/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"node-nlp": "^4.27.0",
"node-schedule": "^2.1.1",
"nodemailer": "^6.7.8",
"nodemailer": "^10.0.1",
Comment on lines +7514 to 7518
"version": "10.0.10",
"resolved": "https://registry.npmjs.org/nodemailer/-/nodemailer-10.0.10.tgz",
"integrity": "sha512-He9XskOFms62SyAKkLu8CcGcYHAo+BSHSsORI8s4PJH8qZgZY4L4lDfvyN0twvmbpyG+eGrxpyBlskj9d9rJ8A==",
"license": "MIT-0",
"engines": {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants