Repository navigation
chore: remove unused root dependencies and lockfile (Issue 4) - #237
Open
Deepesh-Katudia wants to merge 2 commits into
Open
Deepesh-Katudia wants to merge 2 commits into
Deepesh-Katudia wants to merge 2 commits into
Conversation
Nothing at the repo root imports chess.js, dotenv, express, puppeteer-core, sass or socket.io; every service declares and installs its own copies. The root file is kept only for its convenience `--prefix` scripts and the volta Node pin, neither of which needs installed dependencies, so the 2.5k-line root lockfile goes too.
setup-node's `cache: 'npm'` looks for a lockfile at the repo root by default and fails the job when none exists. The root lockfile is gone, so point cache-dependency-path at the four service lockfiles that `npm ci` actually installs from.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes align with the repository’s per-service dependency structure and CI install paths.
Pull request overview
Removes unused root-level npm dependencies and lockfile while preserving per-service installs and fixing npm cache configuration in CI.
Changes:
- Removed root dependency declarations.
- Deleted the obsolete root lockfile.
- Configured CI caching against the four service lockfiles it installs.
File summaries
| File | Description |
|---|---|
package.json |
Retains root scripts and Volta pin without dependencies. |
package-lock.json |
Removes stale root dependency resolution data. |
.github/workflows/ci.yml |
Points npm caching to service lockfiles. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strips the unused
dependenciesblock from the rootpackage.jsonand deletes the 2.5k-line rootpackage-lock.json. Nothing at the repo root imports those packages; every service declares and installs its own. The root file stays for its--prefixconvenience scripts and the volta Node pin.Type of Change
Key Changes
package.json: removedchess.js,dotenv,express(^5),puppeteer-core,sass,socket.io. Scripts and volta pin untouched.package-lock.json: deleted..github/workflows/ci.yml):setup-nodewithcache: 'npm'looks for a lockfile at the repo root by default and fails the job when there is none. Addedcache-dependency-pathpointing at the four service lockfiles thatnpm ciactually installs from. Without this commit, deleting the root lockfile would break CI.Testing
working-directoryBugs Fixed (if applicable)
TODO (Follow-up Work)
Additional Notes
Independent of the other Issue 4 PRs; can merge in any order.