Skip to content

fix(genesis): sync devnet alloc with DevnetAllocData to restore genesis hash#2439

Open
gzliudan wants to merge 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:fix-devnet-genesis-hash
Open

fix(genesis): sync devnet alloc with DevnetAllocData to restore genesis hash#2439
gzliudan wants to merge 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:fix-devnet-genesis-hash

Conversation

@gzliudan

@gzliudan gzliudan commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Proposed changes

The devnet genesis hash exposed by XDC init devnet diverged from params.DevnetGenesisHash (used by XDC --devnet / DefaultDevnetGenesisBlock). The two paths would have produced different block 0, making nodes initialized via each method unable to peer with one another.

Root cause

Commit 00be1f5 (chore(devnet): may 2026 devnet reset, #2347, 2026-05-25) updated core/genesis_alloc_devnet.go and common/constants.devnet.go as part of a devnet network reset. It added three pre-funded accounts to DevnetAllocData:

4b1a14a10cb48e4cfddd17c379dfcaa358b011bc
d16c20329d391104029d0a850dcdf9ed6e259b60
cc08002e7e4baec892785887a74d35557e8d2c15

params.DevnetGenesisHash was later updated to reflect the new state root in dfce638 (#2329, 2026-05-28).

genesis/devnet.json was NOT touched by either commit; its alloc still contained only the pre-May-2026 eight accounts. Commit 1c0923d (#2354, 2026-07-06) then filled in the config section of devnet.json but again left the alloc unchanged, so the JSON-derived genesis hash remained 0x7dad95... while params.DevnetGenesisHash was 0xb8be00...

Fix

Add the three missing balance-only accounts to genesis/devnet.json alloc, bringing it into parity with DevnetAllocData. After this change:

json.Unmarshal(DevnetGenesis).ToBlock().Hash() == params.DevnetGenesisHash
== 0xb8be003946a9c268...

Verified by running TestEmbeddedGenesisConfigMatchesParams (all three networks pass) and a targeted hash-equality check.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e971ded-8f37-4856-a028-84545832cea7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a devnet startup incompatibility where XDC init devnet (embedded genesis/devnet.json) produced a different genesis hash than XDC --devnet (params/Go-side genesis), preventing nodes initialized via the two paths from peering.

Changes:

  • Add the three missing prefunded accounts to genesis/devnet.json so its alloc matches DevnetAllocData / params.DevnetGenesisHash.
  • Add a regression test ensuring embedded genesis JSON for mainnet/testnet/devnet produces the exact canonical genesis hash constants in params.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
genesis/devnet.json Adds three missing balance-only accounts to devnet alloc to restore genesis hash parity.
core/genesis_load_test.go Adds a hash-parity regression test between embedded genesis JSON and params.*GenesisHash.

Comment thread core/genesis_load_test.go Outdated
…is hash

The devnet genesis hash exposed by `XDC init devnet` diverged from
params.DevnetGenesisHash (used by `XDC --devnet` / DefaultDevnetGenesisBlock).
The two paths would have produced different block 0, making nodes initialized
via each method unable to peer with one another.

Root cause
----------
Commit 00be1f5 (chore(devnet): may 2026 devnet reset, XinFinOrg#2347, 2026-05-25)
updated core/genesis_alloc_devnet.go and common/constants.devnet.go as part of
a devnet network reset.  It added three pre-funded accounts to DevnetAllocData:

  4b1a14a10cb48e4cfddd17c379dfcaa358b011bc
  d16c20329d391104029d0a850dcdf9ed6e259b60
  cc08002e7e4baec892785887a74d35557e8d2c15

params.DevnetGenesisHash was later updated to reflect the new state root in
dfce638 (XinFinOrg#2329, 2026-05-28).

genesis/devnet.json was NOT touched by either commit; its alloc still contained
only the pre-May-2026 eight accounts.  Commit 1c0923d (XinFinOrg#2354, 2026-07-06)
then filled in the config section of devnet.json but again left the alloc
unchanged, so the JSON-derived genesis hash remained 0x7dad95... while
params.DevnetGenesisHash was 0xb8be00...

Fix
---
Add the three missing balance-only accounts to genesis/devnet.json alloc,
bringing it into parity with DevnetAllocData.  After this change:

  json.Unmarshal(DevnetGenesis).ToBlock().Hash() == params.DevnetGenesisHash
                                                 == 0xb8be003946a9c268...

Verified by running TestEmbeddedGenesisConfigMatchesParams (all three networks
pass) and a targeted hash-equality check.
@gzliudan gzliudan force-pushed the fix-devnet-genesis-hash branch from a9a9b8a to 87cb04e Compare July 6, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants