Repository navigation
Fix for AIESW-45264 - #59
Merged
Merged
Conversation
Stripped kernel names can cover several ELF functions, so keep every instantiation and pick the one whose template arguments match the layer. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
funcs_by_elfused to map a stripped kernel name to a singleAIEFunction. When one ELF contained two kernels with the same base name, the last write won, so later stamps looking up that name got the wrong start PC and armed the breakpoint at the wrong address.AIEFunctions._pick_instantiationruns bothstamp.name(mladf) andfunc.name(ELF) through_template_key, which reduces each name so the two sources spell identically. It looks the layer's reduced name up in that dict and returns the matchingAIEFunction.objdump -Cspell the same instantiation differently ('\x01'vs1; defaulted type args omitted vs filled in).