feat(tool-script): add exec_command parameter schema with yield_time_ms and workdir - #2180
Merged
Merged
Conversation
…ms and workdir Define a typed ExecCommandParameters schema (cmd, yield_time_ms, workdir) so exec_command no longer leaks bash's internal parameter names to code-mode callers. The args are translated via execCommandArgs before dispatch. Also update the generated type declarations, tool catalog description, and script guidance to document the new interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Define a typed
ExecCommandParametersschema (cmd,yield_time_ms,workdir) soexec_commandno longer leaks bash's internal parameter names to code-mode callers. The args are translated viaexecCommandArgsbefore dispatch.Changes
ExecCommandParameterszod schema withcmd,yield_time_ms, andworkdirfieldsexecCommandArgs()helper that maps{ cmd, yield_time_ms, workdir }→{ command, timeout, workdir, description }exec_commandto document the new parameters{ cmd, yield_time_ms?, workdir? }interfaceyield_time_msof 10000 msTest plan
exec_commandmaps to bash while direct bash remains backward compatibleexec_commanddefaultsyield_time_msto 10000 ms