fix(security): harden command permissions and credential handling - #2074
Open
YOMXXX wants to merge 10 commits into
Open
fix(security): harden command permissions and credential handling#2074YOMXXX wants to merge 10 commits into
YOMXXX wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR groups the completed security, reliability, and TUI fixes on the branch:
bash_deleteconfirmation for destructive commands, includingcmd /c del,cmd.exe /c del,rd,rmdir, anderase.$env:*paths, before execution and requestexternal_directorypermission.present.SECURITY.mdvulnerability-reporting link toXiaomiMiMo/MiMo-Code.toolChoice: "none"to preserve prefix-cache reuse without enabling compaction tools.xiaomi-token-plan-cnto MiMo's built-in websearch backend instead of Exa.Root causes
Destructive command detection missed wrapped Windows commands, PowerShell output destinations were absent from external-directory scanning, sensitive token output exposed a token prefix, HTTP API authentication used ordinary string comparison, compaction sent a separate empty system/tools prefix, autocomplete used JavaScript string length instead of terminal display width for CJK labels, and websearch matched only the exact
xiaomiprovider ID.Validation
packages/opencode:bun typecheckpassedgit diff --checkpassedThe repository pre-push hook also runs a root typecheck that currently fails because
@typescript/native-preview-darwin-x64is missing locally. The package-level checks above passed; the branch was pushed with--no-verifywithout changing the lockfile.