Repository navigation
Conversation
Add policy storage, admin management APIs, CLI templates, and per-call RPC enforcement. Propagate policy snapshots and admin identity through STS and both signature verifiers. Use cel.dev/cel-go, preserve DENY precedence and conditional filters, and fail closed when attached documents are unavailable. Cover policy evaluation, admin recovery, and cached metadata propagation with regression tests. Signed-off-by: Xe Iaso <me@xeiaso.net>
Owner
Author
|
/reviewbot |
Contributor
|
The latest Buf updates on your PR. Results from workflow Go / build (pull_request).
|
Signed-off-by: Xe Iaso <me@xeiaso.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iamd now enforces attached IAM policy documents on its signed RPC routes. Administrators manage immutable policies and attachments through PolicyService or the iam CLI; non-admin callers require an applicable ALLOW, and every applicable DENY takes precedence.
The evaluator uses concrete request and principal protobuf types with
cel.dev/cel-go v0.32.0. Conditional DENY rules, malformed filters, wildcard boundaries, missing policy documents, and admin recovery all retain fail-closed behavior. Both STS response types and verifier caches carry policies and admin identity for downstream enforcement.The repository's application imports use the canonical CEL module. The old module remains indirectly required by Protovalidate and the OpenAPI generator.
Validation:
npm testpassed, including generation, formatting, andgo test ./....iam/authz,cmd/iamd/..., and both iamsts verifier packages.Other applications still need to install their own enforcement. Downstream policy revocation remains bounded by the server-advised verifier cache TTL.