feat: Add MyFifthAlgorithm, MySixthAlgorithm, MyFirstPotentiallyIllegalAlgorithm, MySecondPotentiallyIllegalAlgorithm, MyRulesLawyerAlgorithm and test cases 23, 24, and 25 - #15
Open
kcinsoft wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can make separate PRs for each algo/the tests if needed, but considering that I expect half of these to be rejected, I'd like to hold off on doing that for now :)
Tests:
case23: breaksMyFirstAlgorithm,MySecondAlgorithm, andOurSecondAlgorithmcase24: regression test, broke an algo while I developed itcase25: regression test, broke an algo while I developed itAlgorithm Summaries:
MyFifthAlgorithmEssentially just further iteration on my initial algorithms (
MyFirstAlgorithm,MySecondAlgorithm,TheThirdAlgorithm,TheFourthAlgorithm), but with some stuff thrown in from the other leading algos.MySixthAlgorithmSame thing as MyFifth, but with some optimizations. Nothing ground breaking, but would occasionally perform worse than MyFifthAlgorithm, so I left it in.
A Note on Player Implementations
Both
MyFifthAlgorithmandMySixthAlgorithmuseMyStarvingPlayeras it's player implementation (different files, still credited), because it being merged into main implies that everything occurring in there is "legal". More on why there's a bit of a gray area there below.MyFirstPotentiallyIllegalAlgorithmandMySecondPotentiallyIllegalAlgorithmMyFirstPotentiallyIllegalAlgorithmandMySecondPotentiallyIllegalAlgorithmare variants of the algorithms above, but offloading some work onto the player that is arguably in the spirit of the rules. I think that you could make these much faster, but that seemed like a waste of time without knowing if this is actually allowed or not.MyRulesLawyerAlgorithmContext: rules lawyer
By the letter of the law (and some really stretched logic), this is, as the rules are written, arguably technically allowed. It does some absolutely nasty things like:
But I think it (and this "algorithm") are really funny, so I'm adding it anyways
AI use:
Harness: Claude Code
Model: Opus 4.7 - high effort
If it wasn't made clear by the sheer amount of code each algorithm has, I extensively used AI to write this (and my previous algorithms). If any of these end up being used, I'd be more than willing to manually rewrite these into a more readable format if desired - we'd probably lose a little bit of speed, but imo its worth it for maintainability.
The Numbers
FullEquip

OneByOne
