Fix unbound ctx.onerror on streamed response Counter (PROD-84255) - #122
Merged
Conversation
Client disconnect during a streamed response (no Content-Length) caused Counter to emit error with riviere's unbound ctx.onerror, throwing inside Koa's error handler and crashing the process. Bind the handler and add a regression test. Bump to 1.22.1. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorwith riviere's unboundctx.onerror, throwing inside Koa's error handler and crashing the process. Bind the handler.errorwith a non-arrowonerror. Latent since Calculate content length for responses when not available in header #44; exposed by Koa 3Stream.pipelineafter orka 5.2.0.@workablehr/riviere@1.22.1.Test plan
npm test— 113 passingTypeError: Cannot read properties of undefined (reading 'emit')v1.22.1to trigger GitHub release + npm publish@workablehr/riviereto^1.22.1and confirm Honeybadger fault 133034050 stopsMade with Cursor