Skip to content

iAPI: align server-side negation truthiness with client side#11804

Open
shrivastavanolo wants to merge 1 commit into
WordPress:trunkfrom
shrivastavanolo:fix/iAPI-directive-negation-logic
Open

iAPI: align server-side negation truthiness with client side#11804
shrivastavanolo wants to merge 1 commit into
WordPress:trunkfrom
shrivastavanolo:fix/iAPI-directive-negation-logic

Conversation

@shrivastavanolo
Copy link
Copy Markdown

The Interactivity API supports a negation prefix ! in directive values. However, the server-side negation logic relies on PHP's native boolean casting, which disagrees with JavaScript on two values:

  • [] (empty array): falsy in PHP, truthy in JavaScript.
  • '0' (string zero): falsy in PHP, truthy in JavaScript.

This causes a mismatch between server and client rendering of the same state, breaking the hydration contract of the Interactivity API.

This fix updates the server-side negation logic in WP_Interactivity_API::evaluate() to use JavaScript-compatible truthiness rules for these two cases, ensuring server and client rendering agree.

Trac ticket: https://core.trac.wordpress.org/ticket/62628

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreya0shrivastava.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant