Skip to content

Upgrade/Install: Use a clean plugin slug for the plugin details URL on the Updates screen#11798

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:trac-65218-clean-plugin-slug
Open

Upgrade/Install: Use a clean plugin slug for the plugin details URL on the Updates screen#11798
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:trac-65218-clean-plugin-slug

Conversation

@itzmekhokan
Copy link
Copy Markdown

The View version X details. link rendered by list_plugin_updates() on the WordPress Updates screen uses $plugin_data->update->slug directly when building the plugin-install.php?tab=plugin-information&plugin=... URL. In some cases this value is empty or includes the parent folder (e.g. plugin/plugin.php) instead of a clean plugin slug, producing a malformed details URL. The api.wordpress.org redirects mask this, but the URL is still incorrect and inconsistent with the link rendered on the Plugins screen.

This adds a small defensive fallback that derives the slug from the plugin directory name (matching the pattern already used in WP_Plugin_Upgrader) whenever the update response does not provide a clean slug.

Props timse201.
See #65218.

Trac ticket: https://core.trac.wordpress.org/ticket/65218

…n the Updates screen.

The `View version X details.` link rendered by `list_plugin_updates()` on the
WordPress Updates screen uses `$plugin_data->update->slug` directly when
building the `plugin-install.php?tab=plugin-information&plugin=...` URL. In
some cases this value is empty or includes the parent folder (e.g.
`plugin/plugin.php`) instead of a clean plugin slug, producing a malformed
details URL. The api.wordpress.org redirects mask this, but the URL is
still incorrect and inconsistent with the link rendered on the Plugins screen.

This adds a small defensive fallback that derives the slug from the plugin
directory name (matching the pattern already used in `WP_Plugin_Upgrader`)
whenever the update response does not provide a clean slug.

Props timse201.
See #65218.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant