Skip to content

Media: Increase attachments browser toolbar height to fit filter controls#11797

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:23562-media-header-overflow
Open

Media: Increase attachments browser toolbar height to fit filter controls#11797
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:23562-media-header-overflow

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented May 11, 2026 •
edited
Loading

Trac ticket: https://core.trac.wordpress.org/ticket/23562

Screenshots

Before

image

After

image

Use of AI Tools

None

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano t-hamano marked this pull request as ready for review May 12, 2026 03:03
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano @claude
Media: Fix toolbar overflow
128c470 
Raise the attachments browser toolbar from 48px to 60px so the 2-row grid of filter labels and selects no longer overflows, and shift the attachments wrapper top from 72px to 84px to keep the gap consistent.

See #23562.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@t-hamano t-hamano force-pushed the 23562-media-header-overflow branch from 688ce9c to 128c470 Compare May 12, 2026 03:11
mukeshpanchal27
mukeshpanchal27 reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Height issue in Ipad screen

Image

@t-hamano
Copy link
Copy Markdown
Contributor Author

t-hamano commented May 12, 2026

Height issue in Ipad screen

@mukeshpanchal27 This is a known issue. See #10832 (comment)

This PR addresses an issue causing an overflow in the desktop layout. Resolving similar issues across all layouts would require additional effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-hamano @mukeshpanchal27