#499 UI: Align URL Field Globe Icon Inside the URL Input Box.#500
Merged
cbravobernal merged 1 commit intoJul 14, 2026
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Thanks @cbravobernal |
This was referenced Jul 15, 2026
ockham
added a commit
that referenced
this pull request
Jul 20, 2026
* Restore upstream sass structure: entries import partials again SCF's four main sass entry files (acf-input, acf-global, acf-field-group, acf-dark) had been flattened into compiled CSS with no imports, orphaning the _*.scss partials. The partials kept receiving upstream syncs (e.g. the 6.8.1 backport) while the flattened entries were edited separately, so the two sources diverged and several upstream style updates never shipped (schema-picker dropdowns, google-map toolbar buttons, copyable field keys, ai_description option styling, and more). Sync all entries and partials verbatim from upstream ACF 6.8.5 (trunk's current parity level), adding the previously missing _ai-admin.scss. Upstream has used the @use module system for these files since before 6.8.5, so future upstream CSS changes can now be ported as plain patches to the partials. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Strip commercial upsell CSS from the synced partials SCF ships no licensing or upgrade UI, so remove upstream's commercial blocks from the freshly synced partials, each marked with an "SCF:" comment for future ports: - acf-global.scss: drop the pro-upgrade module (entirely upsell UI) - _updates.scss: license information panel (#acf-license-information) - _list-table.scss: inactive-license row states (.acf-pro-inactive-license) - _admin-toolbar.scss: upgrade nav, WP Engine logo and upsell pills - _icons.scss: license page heading icon and selector references This matches what SCF's shipped CSS already (correctly) excluded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Preserve SCF URL globe icon centering in _fields.scss Re-apply #500 (vertically center the URL field globe icon), which the flattened acf-input.scss carried but the stale partial lacked. Upstream adopted the identical change in ACF 6.8.6, so this deviation disappears with the next sync. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * s/upstream/ACF/g * Strip remaining PRO-tier CSS missed by the first upsell pass Follow-up to the upsell strip: remove ACF PRO styling that no SCF markup or script can ever render, each marked with an "SCF:" comment: - _field-picker.scss: .field-type-requires-pro chip (references pro-chip*.svg images that do not exist in SCF) and the .field-type-upgrade-to-unlock button; .acf-btn-pro dropped from a selector group - _btn.scss: .acf-btn-pro gradient variant (the browse-fields-modal JS branch that would show it is permanently disabled in SCF) - _global.scss, _acf-headerbar.scss, _field-group.scss: .acf-pro-label / .acf-pro-label-field-type badges - _list-table.scss: .acf-options-pages-preview-upgrade-button and .acf-ui-options-page-pro-features-actions - _admin-toolbar.scss: .acf-requires-pro pill and the PRO logo variant (.acf-logo.pro) The only remaining "pro" references in built CSS are the inert :not(.acf-field-group-pro-features-title...) exception clauses kept for parity with upstream selectors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Delete the unused _pro-upgrade.scss partial Nothing imports it since acf-global.scss stopped using the module: it is 492 lines of commercial upsell UI (header upgrade button, pro-features metabox) contributing zero bytes to the built CSS. The comment in acf-global.scss now notes the file is intentionally absent so future ACF syncs don't reintroduce it by accident. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to resolve #499 . the issue is the globe icon in url field does not aligned in center. I added css to make it center aligned.
Closes #499