Skip to content

fix: Plugin "Check it!" button fails silently with nonce error #893 #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmfoysal06 wants to merge 4 commits into
base: trunk
Choose a base branch
from
+14 −0
Open

fix: Plugin "Check it!" button fails silently with nonce error #893 #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
224f886
fix: Plugin "Check it!" button fails silently with nonce error #893
kmfoysal06 Jul 26, 2026
de72cbc
fix lint errors
kmfoysal06 Jul 26, 2026
5bb4fdb
fix: enhance client error handling and accessibility in admin page
kmfoysal06 Aug 4, 2026
0c31eb8
fix: correct formatting in error handling for client error display
kmfoysal06 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions assets/js/plugin-check-admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
'plugin-check__export-controls'
);
const spinner = document.getElementById( 'plugin-check__spinner' );
const clientError = document.getElementById( 'plugin-check__client-error' );
const pluginsList = document.getElementById(
'plugin-check__plugins-dropdown'
);
Expand All @@ -21,6 +22,7 @@
! resultsContainer ||
! exportContainer ||
! spinner ||
! clientError ||
! categoriesList.length ||
! typesList.length
) {
Expand Down Expand Up @@ -83,6 +85,9 @@
checkItButton.disabled = true;
pluginsList.disabled = true;
spinner.classList.add( 'is-active' );
clientError.innerText = '';
clientError.classList.add( 'is-hidden' );

for ( let i = 0; i < categoriesList.length; i++ ) {
categoriesList[ i ].disabled = true;
}
Expand All @@ -106,6 +111,10 @@
resetForm();
} )
.catch( ( error ) => {
clientError.innerText = error.message;
clientError.classList.remove( 'is-hidden' );
clientError.focus();

console.error( error );

resetForm();
Expand Down
4 changes: 4 additions & 0 deletions includes/Admin/Admin_Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,10 @@ public function admin_footer() {
.plugin-check__export-controls.is-hidden {
display: none;
}
/** Plugin Check Client Errors **/
#plugin-check__client-error.is-hidden {
display: none;
}
</style>
<?php
}
Expand Down
1 change: 1 addition & 0 deletions templates/admin-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

<input type="submit" value="<?php esc_attr_e( 'Check it!', 'plugin-check' ); ?>" id="plugin-check__submit" class="button button-primary" />
<span id="plugin-check__spinner" class="spinner" style="float: none;"></span>
<div class="notice notice-error is-hidden" role="alert" tabindex="-1" id="plugin-check__client-error"></div>
<div class="plugin-check__options">
<div>
<h4><?php esc_attr_e( 'Categories', 'plugin-check' ); ?></h4>
Expand Down
Loading