revert(payment): revert #141 single-node issuer over-query window#143
Merged
jacderida merged 1 commit intoJun 14, 2026
Merged
Conversation
…y window Reverts PR WithAutonomi#141 (fix(payment): verify single-node issuer closeness against over-query window), restoring the paid-quote issuer close-group check to the form left by WithAutonomi#140: an XOR-only local routing-table lookup (find_closest_nodes_local_by_distance_with_self) against the configured close_group_size, with no 2 * close_group_size over-query widening and no local->network hybrid fallback. PR WithAutonomi#139 (widen paid-quote issuer admission to close group + margin) was already fully superseded and reverted by WithAutonomi#140 (use XOR-only local lookup for close-group verification): WithAutonomi#140 removed the storage_admission_width import and restored the close_group_size width. No WithAutonomi#139 residue remains in the tree, so no separate revert of WithAutonomi#139 is required. WithAutonomi#140 is kept intentionally. This reverts commit d797cb8. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Hermes review for PR #143Verdict: LGTM / no blockers found — safe to merge once the remaining matrix test jobs finish green. I reviewed this as the revert of #141 while keeping #140 intact. What I verified
Local checks
CI status when checkedPassing: build jobs, clippy, docs, format, security audit, no-logging test. No code issues found; I would merge after those pending tests complete successfully. |
mickvandijke
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PR #141 (fix(payment): verify single-node issuer closeness against over-query window), restoring the paid-quote issuer close-group check in
src/payment/verifier.rsto the form left by #140:find_closest_nodes_local_by_distance_with_self)close_group_size2 * close_group_sizeover-query wideningWhy #139 needs no separate revert
The intent was to revert #139 and #141 while keeping #140. PR #139 (widen paid-quote issuer admission to close group + margin) was already fully superseded and reverted by #140 (use XOR-only local lookup for close-group verification): #140 removed the
storage_admission_widthimport and restored theclose_group_sizewidth. No #139 residue remains in the tree (grep storage_admission_width src/payment/verifier.rsis empty), so reverting #141 alone yields the exact desired end state. #140 is kept intentionally.Verification
cargo build(debug) ✅cargo fmt --all -- --check✅cargo clippy --all-features -- -D clippy::panic -D clippy::unwrap_used -D clippy::expect_used✅This reverts commit d797cb8.
🤖 Generated with Claude Code