Skip to content

revert(payment): revert #141 single-node issuer over-query window#143

Merged
jacderida merged 1 commit into
WithAutonomi:rc-2026.6.2from
jacderida:chore-revert_139_141
Jun 14, 2026
Merged

revert(payment): revert #141 single-node issuer over-query window#143
jacderida merged 1 commit into
WithAutonomi:rc-2026.6.2from
jacderida:chore-revert_139_141

Conversation

@jacderida

Copy link
Copy Markdown
Collaborator

Summary

Reverts PR #141 (fix(payment): verify single-node issuer closeness against over-query window), restoring the paid-quote issuer close-group check in src/payment/verifier.rs to the form left by #140:

  • XOR-only local routing-table lookup (find_closest_nodes_local_by_distance_with_self)
  • against the configured close_group_size
  • no 2 * close_group_size over-query widening
  • no local→network hybrid fallback

Why #139 needs no separate revert

The intent was to revert #139 and #141 while keeping #140. PR #139 (widen paid-quote issuer admission to close group + margin) was already fully superseded and reverted by #140 (use XOR-only local lookup for close-group verification): #140 removed the storage_admission_width import and restored the close_group_size width. No #139 residue remains in the tree (grep storage_admission_width src/payment/verifier.rs is empty), so reverting #141 alone yields the exact desired end state. #140 is kept intentionally.

Verification

  • cargo build (debug) ✅
  • cargo fmt --all -- --check
  • cargo clippy --all-features -- -D clippy::panic -D clippy::unwrap_used -D clippy::expect_used

This reverts commit d797cb8.

🤖 Generated with Claude Code

…y window

Reverts PR WithAutonomi#141 (fix(payment): verify single-node issuer closeness
against over-query window), restoring the paid-quote issuer close-group
check to the form left by WithAutonomi#140: an XOR-only local routing-table lookup
(find_closest_nodes_local_by_distance_with_self) against the configured
close_group_size, with no 2 * close_group_size over-query widening and no
local->network hybrid fallback.

PR WithAutonomi#139 (widen paid-quote issuer admission to close group + margin) was
already fully superseded and reverted by WithAutonomi#140 (use XOR-only local lookup
for close-group verification): WithAutonomi#140 removed the storage_admission_width
import and restored the close_group_size width. No WithAutonomi#139 residue remains
in the tree, so no separate revert of WithAutonomi#139 is required. WithAutonomi#140 is kept
intentionally.

This reverts commit d797cb8.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dirvine

dirvine commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Hermes review for PR #143

Verdict: LGTM / no blockers found — safe to merge once the remaining matrix test jobs finish green.

I reviewed this as the revert of #141 while keeping #140 intact.

What I verified

Local checks

CI status when checked

Passing: build jobs, clippy, docs, format, security audit, no-logging test.
Still pending: macOS/Ubuntu/Windows full test jobs.

No code issues found; I would merge after those pending tests complete successfully.

@jacderida jacderida merged commit b3c9606 into WithAutonomi:rc-2026.6.2 Jun 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants