Fix bookshelf item loss with use-vanilla-hopper - #884
Open
wling-art wants to merge 4 commits into
Open
Conversation
HaHaWTH
requested changes
Aug 18, 2026
HaHaWTH
reviewed
Aug 18, 2026
HaHaWTH
left a comment
HaHaWTH
left a comment
Member
There was a problem hiding this comment.
这里的comment可以去掉 或者只留// copy if reference equal
HaHaWTH
approved these changes
Aug 18, 2026
HaHaWTH
requested changes
Aug 19, 2026
HaHaWTH
left a comment
HaHaWTH
left a comment
Member
There was a problem hiding this comment.
mb, 看错了一个地方 你没加那个reference比较 removeItem也会修改itemstack的
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopperPull 在转移成功后会无条件把剩余数量回写源容器，补丁逻辑假设 removeItem() 返回的是独立拷贝（普通容器确实如此），但雕文书架的 removeItem 直接返回槽位里原来那个对象引用而不做拷贝，导致回写时改的其实是已经插入漏斗里的那个同一对象。最终漏斗和书架指向同一个 count=0 的幽灵 ItemStack，两边都变空，书凭空消失。
Fix #883