docs: fix stale embedding probe batch sizes and CLI profile activation - #199
Open
detail-app[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 3c269b8 moved the embedding preflight probe batch sizes from 1 and 4 to 1 and 8 (persisted via the new runtime-owned batch settings under application-local.properties) and changed the CLI launcher to activate spring.profiles.active="cli,$SPRING_PROFILE" so the local profile loads the 8/8.0 batch defaults. Three living docs were left describing the old behavior.
A developer following docs/pipeline-commands.md to run the CLI directly would activate only the cli profile, so application-local.properties (app.embeddings.batch-max-concurrent-requests=8, app.embeddings.batch-requests-per-second=8.0) would never load, leaving ingestion at the application.properties defaults of 1 and 1.0 — an ~8x slowdown for local ingestion.
Introduced by commit 3c269b8 (@WilliamAGH, #192)
Doc Drift PRs can be configured here.