chore: remove dead Diagnostics streaming-chunk configuration - #174
Open
detail-app[bot] wants to merge 1 commit into
Open
chore: remove dead Diagnostics streaming-chunk configuration#174detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused Diagnostics configuration section: the Diagnostics.java
class, its field/getter/setter and validation wiring in AppProperties, and
the app.diagnostics.* properties in application-dev.properties.
The only production consumers were in ResilientApiClient, which was
deliberately deleted in the OpenAI SDK integration commit (1690399,
"Remove ResilientApiClient (replaced by SDK integration)"). Since then
the diagnostics values were bound by Spring but never read - no
production call-sites for getDiagnostics(), isStreamChunkLogging(), or
getStreamChunkSample(), and no test references either.
History
Dead Code PRs can be configured here.