Skip to content

fix(android): stop a failed download from crashing the app #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonWildMe merged 1 commit into from
Sep 23, 2026
Merged

fix(android): stop a failed download from crashing the app #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion patches/react-native-fs+2.20.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ index 5ddd941..058d47e 100644
};

diff --git a/node_modules/react-native-fs/android/src/main/java/com/rnfs/RNFSManager.java b/node_modules/react-native-fs/android/src/main/java/com/rnfs/RNFSManager.java
index 351ac06..5aa4ea4 100644
index 351ac06..b7f5be0 100644
--- a/node_modules/react-native-fs/android/src/main/java/com/rnfs/RNFSManager.java
+++ b/node_modules/react-native-fs/android/src/main/java/com/rnfs/RNFSManager.java
@@ -638,6 +638,7 @@ public class RNFSManager extends ReactContextBaseJavaModule {
Expand All @@ -34,6 +34,17 @@ index 351ac06..5aa4ea4 100644

promise.resolve(statMap);
} catch (Exception ex) {
@@ -975,7 +976,9 @@ public class RNFSManager extends ReactContextBaseJavaModule {
return;
}

- promise.reject(null, ex.getMessage());
+ // React Native's Kotlin Promise.reject throws on a null code; thrown from the download
+ // thread, that crashed the app whenever a download failed.
+ promise.reject("EUNSPECIFIED", ex.getMessage(), ex);
}

private void rejectFileNotFound(Promise promise, String filepath) {
diff --git a/node_modules/react-native-fs/index.d.ts b/node_modules/react-native-fs/index.d.ts
index da3fa7d..dc6f060 100644
--- a/node_modules/react-native-fs/index.d.ts
Expand Down
Loading