Repository navigation
Stop syncing cw_cache/ contents between hosts - #30
Conversation
cw_cache/ is generated per host, not deployed, but it was not in the rsync exclude list: a full-tree sync shipped staging's copy over each appserver's, and --delete-after removed any entry only that host had. Now excluded the same way cache/, images/ and l10n_cache/ already are — the directory still lands, only its contents are skipped, and since --delete-excluded is not passed the receiver's own files there are protected. vendor/ stays synced deliberately: it is gitignored, so an appserver has no other way to get it. Shim 2.2.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QKzD8eUV1sT45NMNnjKSAg
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangescw_cache synchronization
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change limits synchronization to the directory contents while preserving each host’s generated cache files, with targeted tests covering the exclude and deletion behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cw_cache/is generated per host rather than deployed, but it was not in the rsync exclude list. A full-tree sync therefore shipped staging's copy over each appserver's, and--delete-afterremoved any entry only that host had.It now sits alongside
cache/*,images/*andl10n_cache/*inRSYNC_EXCLUDES. Two details worth being explicit about:--delete-excludedis not passed, so each receiver's owncw_cachefiles are protected from--delete— appservers keep what they generated instead of having it deleted for not being on staging.vendor/stays synced deliberately, and the new test pins that: it is gitignored, so an appserver has no other route to it.Shim bumped to 2.2.1. The version paragraph in
docs/SALT-INTEGRATION.mdand the "excludes carried over unchanged" claim indocs/OPEN-QUESTIONS.mdare corrected to match.Verification
New shim test asserts the four per-host excludes are present,
vendoris absent, and--delete-excludedstays off. Shim suite 112 tests, 109 passing — the 3 failures are the pre-existingDependencyInstallTestrsync cases that cannot run in my container (command not found: rsync, no package access); CI installs rsync, so they run there. PHP suite 236/236 green, Pint clean.Not included
SCAN_IGNORED— the tree-scan's "never a checkout" set — does not listcw_cacheeither, so discovery still walks it. Different code path from the sync, and out of scope for this change; happy to follow up if wanted.Generated by Claude Code
Summary by CodeRabbit
Bug Fixes
cw_cache/contents from being synchronized or deleted across hosts.cw_cache/directory while excluding its generated contents from deployments..gitdata as intended.Documentation