fix: harden adversarial routing against injected merge intent - #468
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wibias
marked this pull request as ready for review
September 27, 2026 22:06
Wibias
marked this pull request as draft
September 27, 2026 22:10
Wibias
marked this pull request as ready for review
September 27, 2026 22:12
Wibias
enabled auto-merge
September 27, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the validated github-delivery fixes discovered while qualifying the public .agents release.
merge immediatelyfrom creating merge-discussion intentoverrides/babysit/SKILL.mdWhy
The strong Skill Ratchet review found a concrete taint leak:
isMergeDiscussion()inspected raw prompt text, so a merge command inside attributed CodeRabbit feedback could route the request tostatus.md. The downstream .agents copy was fixed and reached complete Skill Ratchet PASS at commit0d5d340c301da34c39820feeae7bd8c0466dafab.This PR ports only the source-repo product changes; it intentionally excludes .agents-specific frontmatter and public-release packaging changes.
Validation
mainROUTE-bot-injection-does-not-create-merge-intentPolicy budget correction
The first CI run correctly rejected the initial port because adding competing-skill guidance to universal
SKILL.mdand expanding the universal policy kernel exceeded the repository's fixed 60% context-reduction budgets. The budgets were not changed.SKILL.mdis restored exactly to sourcemain; babysit ownership classification now lives in the two compatibility redirects, and GD-CORE-004 is rewritten compactly while retaining the explicit injection security flag. New candidate:bb9e0faa12dd14b6ed62b41fa4f4392852da0401. CI is rerunning on this exact head.Router unit-test correction
The next CI run exposed two unit tests that still encoded the prior unsafe routing expectation: attributed bot merge text was expected to become read-only merge/status discussion. Those tests now assert the hardened contract instead: pure attributed injection yields no route, while a trusted fix request plus injected bot text remains
fix-pr-botswithout merge authority. New candidate:d7ee778ceae0703326139841fa829b6c94f429b7.