Update languages.csv#2486
Conversation
Added the full Te Reo Maori (mi) plural form formula, which allows for different translations for cases where n is greater than 10.
| mh,Marshallese,2,n != 1 | ||
| mhr,Meadow Mari,2,n != 1 | ||
| mi,Maori,2,n > 1 | ||
| mi,Maori,3,n == 1 ? 0 : n < 10 ? 1 : 2; |
There was a problem hiding this comment.
Looking through my installation, to see if there was a place I could make a change to test this new fomat, I noticed in weblate/lang/data.py there are a bunch PLURAL_NAMES defined as sets of formats (e.g. ONE_OTHER_PLURALS which seems to be all the plural formats that have two values a "single" and a "plural" (or "one" and "other") which includes the old setting for Maori, as well as ONE_FEW_MANY_PLURALS, which I guess should include the new one. Since the new format I've added here doesn't match any of the existing ONE_FEW_MANY_PLURALS, does it need to be added somewhere else as well?
There was a problem hiding this comment.
I've pushed another commit with changes in more places where it's defined (and removed the semi-colon from this entry). Didn't find the names though.
There was a problem hiding this comment.
But those values might be generated based on some rules in the pluralRanges files, so maybe I don't need to make changes for that to work :) 🤞
There was a problem hiding this comment.
Unless I need to add this tag to the TAG_MAP in export-plural-tags.py?
Removed semi-colon from languages.csv entry for Maori
svenddpc
left a comment
svenddpc
left a comment
There was a problem hiding this comment.
Didn't mean to start a review - those should all just have been comments. Always do that :P
| mh,Marshallese,2,n != 1 | ||
| mhr,Meadow Mari,2,n != 1 | ||
| mi,Maori,2,n > 1 | ||
| mi,Maori,3,n == 1 ? 0 : n < 10 ? 1 : 2; |
There was a problem hiding this comment.
I've pushed another commit with changes in more places where it's defined (and removed the semi-colon from this entry). Didn't find the names though.
| mh,Marshallese,2,n != 1 | ||
| mhr,Meadow Mari,2,n != 1 | ||
| mi,Maori,2,n > 1 | ||
| mi,Maori,3,n == 1 ? 0 : n < 10 ? 1 : 2; |
There was a problem hiding this comment.
But those values might be generated based on some rules in the pluralRanges files, so maybe I don't need to make changes for that to work :) 🤞
| mh,Marshallese,2,n != 1 | ||
| mhr,Meadow Mari,2,n != 1 | ||
| mi,Maori,2,n > 1 | ||
| mi,Maori,3,n == 1 ? 0 : n < 10 ? 1 : 2; |
There was a problem hiding this comment.
Unless I need to add this tag to the TAG_MAP in export-plural-tags.py?
| `mh` | Marshallese | nplurals=2; plural=n != 1; | | | | | ||
| `mhr` | Meadow Mari | nplurals=2; plural=n != 1; | | | | | ||
| `mi` | Maori | nplurals=3; plural=n == 1 ? 0 : n < 10 ? 1 : 2; | | | ✔ | | ||
| `mi` | Maori | nplurals=3; plural=n == 1 ? 0 : n < 10 ? 1 : 2; | | | nplurals=2; plural=(n > 1); | |
There was a problem hiding this comment.
This commit by the CI bot seems to be broken? Is that because I made my changes wrong?
| mfe,Morisyen,2,(n > 1) | ||
| mg,Malagasy,2,(n > 1) | ||
| mi,Maori,2,(n == 1 ? 0 : n < 10 ? 1 : 2) | ||
| mi,Maori,2,(n > 1) |
There was a problem hiding this comment.
And is this just undoing my change again? Since these changes are made by a CI bot, I presume that I've done something wrong, or I'm missing something for it to decide to undo my changes?
1 participant
Added the full Te Reo Maori (mi) plural form formula, which allows for different translations for cases where n is greater than 10.