Repository navigation
Un-gate the captcha-blocked auth checks: reCAPTCHA off on the test install (TIGER-385) - #370
Merged
Merged
Conversation
…st install (TIGER-385)
The probe's GATED footer told the operator the three captcha-blocked checks could not be
un-gated by any configuration, and belonged to a headless browser run instead. That was
wrong. `tiger.recaptcha.enabled = 0` is a first-class state in `Tiger_Recaptcha` — the
control renders nothing and the validator passes, by design, so a keyless dev install just
works — and with it off all three run for real against the same code prod runs.
It matters because of WHICH three: AUTH-04 (a failed login is refused with a JSON envelope),
AUTH-05 (login does not enumerate accounts) and AUTH-07 (a reset request does not enumerate
accounts) are the probe's three `blocker`-severity checks. They were the assertions least
able to afford being inconclusive.
Verified both ways on dev rather than asserted: with reCAPTCHA ON the footer renders and
reports 3 GATED; with it OFF the run is 13 checks, 0 failed, 0 GATED, and a real headless
login (`identifier`+`password`, no captcha token) returns `{"result":1,"redirect":"/account"}`
and a 200 on an authenticated page.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013vdyTeoDrGE4hKxt53TsE8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/ui/bin/auth-probe.php's GATED footer told the operator that no configuration un-gates the captcha-blocked checks, and that they belong to a headless browser run instead. That's wrong, and it sent the next person down the expensive path.tiger.recaptcha.enabled = 0is a first-class state inTiger_Recaptcha— documented in its own class docblock ("OFF = the control renders nothing and the validator passes, so forms work in dev with no keys"). Switch it off on a test install and the probe's assertions run for real, against the same code prod runs. The keys stay in place, so re-enabling is the same single value.Why it matters — which three checks
The gated ones were not incidental. They are the probe's three
blocker-severity checks:{result:0, message})Those are the assertions least able to afford being inconclusive, and they had been inconclusive on every run.
Verified both ways on dev, not asserted
Mutation-checked, because a footer that only ever prints one branch proves nothing:
13 checks, 0 failed, 3 GATEDand the new footer renders with the config line.13 checks, 0 failed, 0 GATED.identifier+password, no captcha token) returns{"result":1,"redirect":"/account"}, and an authenticated page fetch returns 200.dev is left with reCAPTCHA off, which is what a test install wants.
Comment-only change to a test tool — no shipped code, no behavior change.
🤖 Generated with Claude Code
https://claude.ai/code/session_013vdyTeoDrGE4hKxt53TsE8