Repository navigation
TIGER-317: emit <meta name="generator" content="Tiger">, flag-defaulted on - #339
Merged
Merged
Conversation
…ed on Tiger announced nothing, while every page already shipped tiger.modal.js, tiger.tabs.js and id="tiger-main" — the silence bought no obscurity, it only kept Tiger out of the technology surveys (W3Techs/BuiltWith/Wappalyzer) that build CMS market-share tables off the generator meta. Now every install is countable, and a site that would rather not be says so in one checkbox. NAME ONLY, never a version. A version string hands a vulnerability scanner the exact build to match CVEs against, across an install base nobody patches on our schedule, and no detector needs it. A guard test enforces the literal so it cannot drift back in. The flag has a DECLARED default, not an inferred one: tiger.site.generator_meta ships = 1 in configs/core.ini, in the site-identity block beside the other keys the CMS Settings screen owns (the cms module itself ships only acl.ini). Stored positively, so the ini reads the way the feature works. - Tiger_Application_Bootstrap seeds $view->showGenerator beside $view->siteName. A missing key still reads as on — the flag fails VISIBLE. - The base theme's public layout emits the tag when it isn't hidden; a view built outside the bootstrap has no such property and still emits. A theme shipping its own layout owns its own head. - Settings > CMS > Site Settings gains "Hide Tiger meta tag". The checkbox asks the opposite question from the flag, and Cms_Service_Settings is the single place the two polarities are reconciled. cms.settings.js sends an explicit "0" because an unchecked box submits nothing — without it the opt-out could never be reversed. - i18n in all seven locales. Tests: the real layout block is lifted out and RENDERED in all three states (shown / hidden / property absent), the shipped ini default is asserted, and the config round trip covers the un-tick. All mutation-checked — a version in the content, an ungated tag, a flipped or deleted ini default, and a reversed polarity each fail the suite. Full suite green: 2545 tests, 22751 assertions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vdyTeoDrGE4hKxt53TsE8
The class docblock named a `tiger.site.hide_generator` config key that does not exist; the flag is stored positively as `tiger.site.generator_meta` (hiding sets it to 0). Comment-only; the test code already asserts the correct key. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tiger announced nothing — no generator meta, no
X-Powered-By, no badge. But every page alreadyships
tiger.modal.js,tiger.tabs.jsandid="tiger-main", so a Tiger site has always beentrivially fingerprintable. The silence bought no obscurity; it only kept Tiger out of the technology
surveys (W3Techs / BuiltWith / Wappalyzer) that build CMS market-share tables off the generator tag.
An install that emits nothing is counted as nobody.
Now every install is countable, and a site that would rather not be says so in one checkbox.
Name only, never a version
A version string here hands a vulnerability scanner the exact build to match CVEs against, across an
install base nobody patches on our schedule — and no detector needs it. The content is a literal and
a guard test enforces that, so it cannot drift back in.
The flag
tiger.site.generator_meta, shipped= 1inconfigs/core.ini— in the site-identity blockbeside
tiger.site.name/home_page/description, the keys the CMS Settings screen alreadyowns. The default is declared, not inferred from a missing key. Stored positively so the ini line
reads the way the feature works.
Tiger_Application_Bootstrapseeds$view->showGeneratorbeside$view->siteName. A missing keystill reads as on — the flag fails visible.
bootstrap has no such property and still emits.
question from the flag, and
Cms_Service_Settingsis the single place the two are reconciled.cms.settings.jssends an explicit"0"— an unchecked box submits nothing, so without it theopt-out could never be reversed.
Tests
The real layout block is lifted out of the shipped file and rendered in all three states
(shown / hidden / property absent), the ini default is asserted, and the config round trip covers
the un-tick. Every one mutation-checked:
content0Full suite green: 2545 tests, 22751 assertions.
Known limits
theme-crafto-interiorandtheme-portodo not, so a site on those won't emit the tag until theirlayouts carry it. Same way
headTitle/headMetaalready behave.W3Techs / Wappalyzer / BuiltWith is the actual marketing payoff and stays on TIGER-317.
TIGER-317
🤖 Generated with Claude Code
https://claude.ai/code/session_013vdyTeoDrGE4hKxt53TsE8