Repository navigation
fix: avoid stale HTTP messenger state - #1633
Merged
kentbull merged 1 commit intoAug 27, 2026
Merged
Conversation
Run the HTTP client doer between request production and response handling, and advance the stream client before inspecting its response queue. Both paths now interpret state produced by the current scheduler recurrence instead of stale state from the previous pass. Add a focused same-recurrence regression for both HTTP messenger variants. No transport completion, cutoff policy, Directant, or retry behavior changes are included.
kentbull
force-pushed
the
fix/http-messenger-doer-order-v1.2.14
branch
from
August 27, 2026 02:18
dab6ea4 to
6037fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
HTTPMessenger currently handles responses before its client doer runs, so it reads transport state left over from the prior scheduler recurrence. HTTPStreamMessenger similarly inspects the response queue before advancing its child client. The reordered paths interpret state produced by the current client service pass.
Scope
This PR contains only the HTTP doer-ordering change and its focused regression. It does not include transport-completion accounting, cutoff policy, Directant lifecycle, retry, timeout, or configuration changes from #1614.
Verification
tests/app/test_agenting.py: 5 passedE9,F63,F7,F82): 0 findingsv1.2.14: one commit, two files