Skip to content

Fixed cmake version related broken configure for StormLib - #494

Draft
ipochto wants to merge 2 commits into
masterfrom
fix/StormLib-configure
Draft

Fixed cmake version related broken configure for StormLib#494
ipochto wants to merge 2 commits into
masterfrom
fix/StormLib-configure

Conversation

@ipochto

@ipochto ipochto commented Apr 17, 2025

Copy link
Copy Markdown
Member

No description provided.

@ipochto ipochto changed the title Fix StormLib cmake version related broken configure Fixed cmake version related broken configure for StormLib Apr 17, 2025
@Jarod42

Jarod42 commented Apr 17, 2025

Copy link
Copy Markdown
Member

Have you tried to update to last version of StromLib?
It should probably be a submodule BTW? https://github.com/Wargus/StormLib

Comment thread .gitmodules
url = https://github.com/Wargus/dependencies
[submodule "StormLib"]
path = StormLib
url = https://github.com/ladislav-zezula/StormLib

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? Our fork is far behind.
This branch is 2 commits ahead of, 330 commits behind ladislav-zezula/StormLib:master

@Jarod42 Jarod42 Apr 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to synchronize it (regularly).
Not sure if our commits are relevant though.

@ipochto
ipochto marked this pull request as draft April 17, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants