Repository navigation
Fix B-01–B-23 security and correctness bugs (v1.4.1) - #5
Merged
Merged
Conversation
Connection-sensitive fixes use safer alts (lifecycle order, auth wait mirroring reconnect, persist-after-ACK, https→wss fail-closed, UDP bind on relay REG). Non-connection hardening covers update SHA-256, Electron sandbox/setcap integrity, server token defaults, and related issues. Co-authored-by: Warexpor <warexpor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes every confirmed finding from the Project bug review (B-01–B-23). Connection-flow-sensitive items use safer alternatives so happy-path connect behavior stays intact where we cannot live-test.
Connection-safe approaches
PeerManager.Stop/ leave cleanuproom_joinedCloseAttempt(non-intentional) mirroring reconnecthttps://always →wss(no silent cleartext downgrade)ip:portOther
Update SHA-256 gate, Electron sandbox + sidecar hash before setcap, server token defaults, owner-token hash-at-rest, WS limits, atomic writes, log perms, invite without password, version 1.4.1.
Test plan
go test ./...inserver/andclient/v1.4.1to run Release workflow (publishesEntangled.exe.sha256)