Skip to content

Dev#37

Open
shieldss wants to merge 4 commits into
mainfrom
dev
Open

Dev#37
shieldss wants to merge 4 commits into
mainfrom
dev

Conversation

@shieldss

@shieldss shieldss commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

refactor

shieldss added 2 commits April 8, 2026 13:48
refactor of list.php

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ab12f6d9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread public/list.php
$row_cnt = ($result instanceof mysqli_result) ? mysqli_num_rows($result) : 0;
?>
<link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css">
<script src="https://code.jquery.com/ui/1.12.1/jquery-ui.js"></script>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Load jQuery before initializing datepicker

The refactor removed the page-level jQuery include but still loads jquery-ui.js and calls $(...) immediately, while footer.php loads jQuery only at the end of the page. On list.php, this means $/jQuery is undefined when the UI plugin and initializer run, so the datepicker controls fail (and can trigger a JS error in the console). Add a jQuery script include before jquery-ui.js (or move the datepicker init to after footer scripts) so the date filter UI works reliably.

Useful? React with 👍 / 👎.

update to fix API timeouts
update to merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant