Repository navigation
Conversation
… bottom On a phone the public call sheet (#/crew/<token>) showed the Accept / Decline pair twice: once in the action card under the shifts and once in the bar fixed to the bottom of the screen. The card's pair was the one crew reported as dead. Tapped with the card low on the screen, it opened the note panel below the fold at the same moment the bar vanished and the page shifted under the thumb, so nothing visible answered the tap; the bar's pair scrolled the card into view and so appeared to work. Now, at 600px and under, the bar is the only pair. The card keeps the question and the note panel, and until a choice is made it points at the bar. Back in the panel brings the bar straight back. Desktop is unchanged: the in-card pair, no bar. The bar's scroll is also fixed properly rather than by luck. It runs before the panel has grown, and with the card near the foot of the page the page could not scroll far enough, so the Confirm button still sat under the fold. The tap now aligns the card to the top (with a scroll margin), and a second pass once the panel has opened nudges only as far as needed. The breakpoint is seeded into state from the media query and written once. Covered by tests/test_crew_view_mobile.js: a hook-capable Node render of the sheet on phone and desktop, including the bar flow, Back, decline, flat-rate and answered requests. Its runner also rejects a hook count that changes between renders, the mistake the real React reports as error #310. Shell cache bumped to v126. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FUTgf6UKLxccdJiN18rjzV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a phone, the public crew call sheet (
#/crew/<token>,modules/crew-view.js) showed the Accept / Decline pair twice: once in the action card under the shifts and once in the bar fixed to the bottom of the screen. Crew reported the card's pair as dead. It did register the tap, but it opened the note panel below the fold at the same moment the bar vanished and the page shifted under the thumb, so nothing visible answered it; the bar's pair scrolled the card into view and so appeared to work.sw.js), as the CI guard requires for a served-file change.Verification
tests/test_crew_view_mobile.js(48 assertions): a hook-capable Node render of the sheet on phone and desktop covering the bar flow, Back, decline, flat-rate and already-answered requests. Its runner also rejects a hook count that changes between renders (React error #310), which caught a misplaced hook during this work.tests/check_shell_version.pypass.Generated by Claude Code