Repository navigation
Conversation
…ng Accepted A request whose every shift had since been cancelled fell through the tab's badge and bucket logic — nothing accepted, nothing confirmed — so it read "Accepted" with no Confirm button and sat in the Open queue, holding its project card there after everyone else on the project was confirmed. The tab now counts cancelled positions: such a request is badged "Cancelled" (ahead of "Paid" and "Booked directly" — a cancelled booking is not a booking) and ranks with the confirmed ones, as a cancellation does everywhere else (crew_integrity's status rank, LTP_crewRequestPay). A request with one shift confirmed and another cancelled still reads Confirmed. A cancelled shift says so in the per-shift list, and the Confirmed tile's tooltip says it holds these. Shell cache bumped to v125 (labor.js is precached). Tests: tests/test_crew_requests_tab.js gains a project with cancellations — the Open queue is empty, the Confirmed tile holds the rows, the badges, chips, action buttons and shift lines read right on desktop and phone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FUTgf3f79qvyv4HCC81iq1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
On Labor → Crew Requests, a request whose shifts had all been cancelled kept its project card in the default Open queue after everyone else on the project was confirmed. The tab never counted positions in the
cancelledstatus, so such a request had nothing accepted and nothing confirmed, fell through to the "Accepted" badge with no Confirm button, and was bucketed as open with nothing to click to clear it.What changed
crew_integrity's status rank,LTP_crewRequestPay). The request leaves the Open queue and sits under the Confirmed tile; the tile's tooltip says it holds these.Left alone on purpose: the paid-out rule that a request with nothing paid at all is never paid out (pinned by
tests/test_crew_request_pay.jsR17). A cancellation at $0 pay therefore keeps its project in the All view until the payout export settles it.Verification
tests/check_shell_version.pypasses.Generated by Claude Code