Skip to content

Fix treasury limits and renew contract storage TTLs - #799

Merged
levoski1 merged 2 commits into
WHEELBACK:mainfrom
kabukkels-sys:resolve-issues-672-675
Sep 28, 2026
Merged

levoski1 merged 2 commits into
WHEELBACK:mainfrom
kabukkels-sys:resolve-issues-672-675

Conversation

@kabukkels-sys

@kabukkels-sys kabukkels-sys commented Sep 26, 2026 •

Copy link
Copy Markdown

Summary

  • Cover cumulative withdraw-limit boundaries, exact 24-hour rollover, and clearing a limit with 0.
  • Renew invoice-entry TTLs on writes and the requested reads; renew contract instance TTLs on mutation.
  • Add approval and execution cost benchmarks with JSON baselines and a 20% tolerance.
  • Keep disputed treasury settlement state alive through instance TTL renewal and cover a long-ledger dispute flow.

Updating benchmark baselines

When a resource increase is intentional, run the corresponding benchmark with the same Soroban SDK, update its cpu_instructions and memory_bytes values and timestamp in the matching resources/*_settlement_baseline.json, and explain the expected increase in the PR. Change tolerance_percent only with reviewer agreement.

Verification

As requested, no compilation or tests were run. git diff --check and baseline JSON parsing passed.

Closes #672
Closes #673
Closes #674
Closes #675

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@kabukkels-sys Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@levoski1
levoski1 merged commit 7712e45 into WHEELBACK:main Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants