Skip to content

Don't skip MoorDyn tests#105

Merged
akeeste merged 6 commits into
WEC-Sim:devfrom
jtgrasb:MoorDyn-v2.5
Jun 2, 2026
Merged

Don't skip MoorDyn tests#105
akeeste merged 6 commits into
WEC-Sim:devfrom
jtgrasb:MoorDyn-v2.5

Conversation

@jtgrasb

@jtgrasb jtgrasb commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

The MoorDyn tests shouldn't fail anymore due to the v2.5 updates.

The tests are still skipped on Linux/Ubuntu because the MoorDyn folder is set up so that the specific architecture needs to be selected manually.

@jtgrasb

jtgrasb commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

The tests are still failing intermittently and causing MATLAB to crash even though they pass locally. Speaking with @akeeste, we decided to skip the tests entirely and continue to test locally when changes are made.

Potential causes include lack of compatibility between dll and github os, dll renaming, file skipping, etc. but these are not worth time at this stage.

@akeeste akeeste self-assigned this May 13, 2026
@jtgrasb

jtgrasb commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Jeff to do: Skip the individual tests including MoorDyn rather than entire folder.

@akeeste akeeste self-requested a review May 13, 2026 14:33
@jtgrasb

jtgrasb commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

I updated the individual tests for MoorDyn to include a catch to not run the test if its being run by GitHub CI. This way, it skips those tests on GitHub but we can easily run them locally.

@akeeste akeeste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jtgrasb ! These tests are running appropriately now: passing locally and being marked as incomplete on the CI which is the most accurate result while still passing all of the completed tests

@akeeste akeeste merged commit ffeabc6 into WEC-Sim:dev Jun 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants