Repository navigation
fix: keep sectors after "in" out of network search geographies - #71
Merged
Merged
Conversation
The parser took everything after the first "in" as a place. "working in climate in Berlin" gave "climate in berlin" and "investors in fintech" gave "fintech", and those words were then dropped from the topics. Read every "in" and "near" phrase, skip the ones that follow a sector word such as working or investors, and stop each place at the next preposition. Fixes #70
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Summary
Geographies now come from every "in" and "near" phrase in the query. A phrase is skipped when "in" follows a sector word such as working or investors. Each place also stops at the next "in" or "near". So "working in climate in Berlin" gives only
berlin. Climate stays a topic. "investors in fintech" gives no geography and keeps fintech as a topic.Open PRs #25 and #33 touch the same geographies line on their own branches. This branch is based on main. A small merge conflict is expected there.
Validation