Repository navigation
fix: match network search criteria as whole words in candidate text - #31
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
containsAny used substring matching and stripped the s from "us", so "partner" matched "partnerships" and "us" matched any text with a u. Fixes #30
VolodymyrLinuxovich
force-pushed
the
fix/network-search-word-match
branch
from
October 9, 2026 02:14
bc34f47 to
e18cdda
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
Summary
containsAnynow matches each variant as a whole word, with an optional plural "s" or "es", instead oftext.includes. "partner" no longer matches "partnerships" and "us" no longer matches "business".tokenVariantsonly strips plural endings from words longer than 3 letters, so "us" is not turned into "u".Validation
tests/network-search.test.ts: for "Find investors in the us", a Berlin partnerships lead is not returned and a US VC partner still matches role and geography. It fails without the fix.npx tsc --noEmit, eslint on the changed files,npx vitest run(176 tests) pass.