feat(runner): add data-plane mode to the fleet config update

[erenaslandev]

Summary by CodeRabbit

• New Features
  • Added baseline_seconds to fleet configuration to define a baseline observation window.
  • Enabled enhanced validation and execution for fleet config_update in data-plane mode, including receiver-suppression checks before applying updates.
• Bug Fixes
  • Updated the fleet automation config_update flow to support both legacy/control-plane and data-plane verification paths.
• Tests
  • Added coverage for data-plane fleet config-update validation, including required generator and nonzero min_received behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 560dbbe3-d236-45c4-9a55-91c56c841200

📥 Commits

Reviewing files that changed from the base of the PR and between f680e40 and 070ab56.

📒 Files selected for processing (1)

• internal/runner/runner.go

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/runner/runner.go

---

Walkthrough

FleetConfig adds baseline_seconds and a data-plane predicate for config_update. Validation now requires a generator and positive min_received in that mode. The runner splits legacy and data-plane config_update handling, adds baseline suppression checks, pushes raw .vmf config, and checks receiver results.

Changes

Fleet config_update data-plane mode

Layer / File(s)	Summary
FleetConfig contracts and validation internal/config/case.go, internal/config/fleet_config_update_test.go	Adds baseline_seconds, BaselineSecondsOrDefault(), and IsConfigUpdateDataPlane(). validateFleet() now requires a generator and min_received > 0 for data-plane config_update, with table-driven tests for valid, invalid, and legacy cases.
Runner data-plane execution path internal/runner/runner.go	Branches config_update into legacy ZIP-based and data-plane raw-VMF paths. The data-plane path samples baseline receiver metrics, pushes update.vmf, waits for min_received, and records content-validation failures from lastRM.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• VirtualMetric/PipeBench#5: Introduces HasGenerator() and CorrectnessConfig.MinReceived, which this PR’s validation rules depend on.
• VirtualMetric/PipeBench#29: Extends the same config_update fleet automation flow in internal/config/case.go and internal/runner/runner.go.

Suggested reviewers

• namles
• yusufozturk

Poem

🐇 A rabbit hopped by with a config cheer,
Baselines were quiet, the path was clear.
Raw vmf sent and metrics grew,
min_received arrived right on cue.
Fleet config_update danced through the night,
Data-plane checks all passed just right.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding fleet config_update data-plane mode support, even though the changes span config and tests too.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch DT-816

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/runner/runner.go`:
- Around line 4004-4026: The baseline suppression check in runner.go is using
the receiver’s lifetime total from queryReceiverMetrics after sleeping, so
pre-window records can be miscounted as leakage. In the Phase 1 block around the
baseline window, capture an initial LinesReceived sample before the sleep, then
compare the post-sleep sample against that baseline delta when evaluating
suppression. Use the existing symbols queryReceiverMetrics, rmBase, baseCount,
and cfgUpdateLeak to keep the change localized.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aecf540d-bb4c-478a-969e-6d1aa925a550

📥 Commits

Reviewing files that changed from the base of the PR and between 3c78e70 and f680e40.

📒 Files selected for processing (3)

• internal/config/case.go
• internal/config/fleet_config_update_test.go
• internal/runner/runner.go

[cloudflare-workers-and-pages]

Deploying pipebench with    Cloudflare Pages

Latest commit:	070ab56
Status:	✅  Deploy successful!
Preview URL:	https://0fd9d0e3.pipebench.pages.dev
Branch Preview URL:	https://dt-816.pipebench.pages.dev

View logs