Skip to content

Prevents removal of machines with active user services #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkmstr merged 1 commit into from
May 22, 2026
Merged

Prevents removal of machines with active user services #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions server/src/uds/core/services/generics/fixed/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,16 @@ def initialize(self, values: 'types.core.ValuesType') -> None:
if not self.machines.value:
raise exceptions.ui.ValidationError(gettext('We need at least a machine'))

# Remove machines not in values from "assigned" set
# Do not allow removing machines that still have assigned user services.
# (their UserService rows would linger, counting against userservices_limit)
with self._assigned_access() as assigned_vms:
assigned_vms &= set(self.machines.as_list())
removed_assigned = assigned_vms - set(self.machines.as_list())
if removed_assigned:
raise exceptions.ui.ValidationError(
gettext('Cannot remove machines with assigned services: {}').format(
', '.join(sorted(removed_assigned))
)
)
self.token.value = self.token.value.strip()

@contextlib.contextmanager
Expand Down
Loading