harden RBAC permissions, move them to proper locations - #2629
Open
AndrewChubatiuk wants to merge 1 commit into
Open
AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 38 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
AndrewChubatiuk
force-pushed
the
harden-rbac
branch
from
September 17, 2026 08:35
4b2ed45 to
13f4cc5
Compare
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 15 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
harden-rbac
branch
from
September 17, 2026 09:49
13f4cc5 to
9bd5004
Compare
Contributor
There was a problem hiding this comment.
1 issue found across 35 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/controller/operator/controllers.go">
<violation number="1" location="internal/controller/operator/controllers.go:324">
P2: The new `+kubebuilder:rbac:groups="",resources=events,verbs=create` marker is attached directly to `createGenericEventForObject` with no blank line, so it becomes the function's doc comment and controller-gen's package-level RBAC collector never reads it. The repository's own `hack/check-rbac-markers.sh` CI gate fails on this line (exit 1). Add a blank line after the marker so it is detached and actually generates the role entry.</violation>
</file>
AndrewChubatiuk
force-pushed
the
harden-rbac
branch
from
September 17, 2026 10:02
9bd5004 to
c7badca
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue #2628