Repository navigation
Accept custom detector text - #38
Merged
Merged
Conversation
Contributor
Author
|
@codex review this PR |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bmarwritescode
approved these changes
Aug 11, 2026
bmarwritescode
left a comment
bmarwritescode
left a comment
Contributor
There was a problem hiding this comment.
Made one comment. I don't feel strongly enough about it to block though, but you should consider the change
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The upload custom detector tool only accepted a file path. This imposes an assumption that the ah and the agent are running in the same environment. This assumption is too strong for MCP running in server mode and in isolation.
Fix
The upload custom detector tool now accepts the text of custom detector and file name. Backwards compatibility is maintained by still accepting a path but the text is preferred