Fix usages from datetime to carbon - #447
Open
matthewfarrugia wants to merge 2 commits into
Open
Conversation
…on::setTestNow() to properly test implementations and matches return value type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#384
Caller code will have functionality around revision and therefore are integration tested.
However since this repo currently uses
DateTimemaking changes to models with often cause thecreated_atdates on the revisions to be exactly the same time - this means revision order is incorrect and tests will intermittently fail due to$model->revisionHistory->latest()having an indeterminate order.Fix
The fix is to use
Carbon::nowinstead ofDateTime(matching the instance type returned by$model->created_at) - using Carbon also allows for faking in tests usingCarbon::setTestNow()- the now time can be changed in order to simulate time between revisions, guaranteeing a reproducible order.