Repository navigation
Upload web images at their device size and charge only real copies - #616
Merged
Merged
Conversation
Uploading an image charged three times its RGBA size against the web rendering budget: a redundant Rust RGBA copy, the browser ImageData copy, and the surface. A 4032x3024 photo needed 139.5 MiB of the 128 MiB budget, so the page failed with "web rendering resource budget exceeded". RGBA pixels now go to ImageData directly, and only non-RGBA pixels are converted first. Images are box-reduced before upload to no fewer pixels than the backing pixels they cover, growing the factor only when needed to fit the budget, so any image the decoder accepts can be drawn. The existing box reduction is exposed as pdf_image::ReduceImage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading an image charged three times its RGBA size against the web
rendering budget: a redundant Rust RGBA copy, the browser ImageData copy,
and the surface. A 4032x3024 photo needed 139.5 MiB of the 128 MiB budget,
so the page failed with "web rendering resource budget exceeded".
RGBA pixels now go to ImageData directly, and only non-RGBA pixels are
converted first. Images are box-reduced before upload to no fewer pixels
than the backing pixels they cover, growing the factor only when needed
to fit the budget, so any image the decoder accepts can be drawn.
The existing box reduction is exposed as pdf_image::ReduceImage.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com