Repository navigation
Consolidate NNTP Listening Transport in Common - #258
Merged
Merged
Conversation
- Extract shared high-performance pipeline listener and connection transport into Common - Migrate Reader, Transit, Storage, and BackFiller listeners to the shared implementation - Fix pipeline stream read, write, and cancellation handling - Improve QUIT completion and command failure logging - Add transport regression tests and update performance documentation - Preserve byte-sensitive INN test fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the high-performance socket listener and pipeline-based connection transport into
VectorNNTPD.Common, providing a shared implementation for ReaderService, TransitService, StorageService, and BackFillerService.This removes duplicated listening-transport implementations while preserving service-specific protocol handling and session logic.
Changes
PERFORMANCE.mdwith the current benchmark baseline and historical comparison limitations..gitattributesconfiguration.Validation
Performance
The shared pipeline transport has a measured post-migration loopback benchmark baseline. Historical BENCHIT results are retained in
PERFORMANCE.md, but the workloads are not directly comparable. Consequently, this PR makes no quantitative before-and-after performance improvement claim.Scope
Service-specific NNTP protocol and session logic remain in their respective services. The change centralizes the listening transport without introducing a separate legacy NNTP server implementation.