Repository navigation
Import Reader and Transit Services; Harden Release Packaging and CodeQL Validation - #256
Merged
Merged
Conversation
…tion** - Import ReaderService and TransitService with corresponding test projects. - Preserve service separation and shared Common architecture. - Package BackFiller, Storage, Reader, and Transit independently for Windows and Linux. - Update release scripts, CI workflows, systemd units, and deployment documentation. - Fix CodeQL findings across production and test code. - Ensure CodeQL performs non-incremental extraction to include all source files. - Correct test resource disposal, exception handling, path operations, and code-quality issues. - Fix profiler test isolation and packaging-contract assertions. - Verify all five test suites and the Release solution build.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Import the ReaderService and TransitService projects and their associated test suites into VectorNNTPD, preserving the existing service architecture while strengthening release packaging, CI validation, and CodeQL analysis coverage.
Changes
Service integration
Release packaging and deployment
CodeQL and code quality
Test reliability
ArticleTransferWindow.Windowbehaviour.Verification
Local Release verification completed successfully:
bin/objoutput.Outstanding validation
GitHub-hosted CodeQL analysis and required PR checks have not yet been verified. They must be confirmed after the branch is pushed and the PR is opened.
Risk and compatibility notes
ArticleTransferWindow.Windowproperty is intentionally unchanged to preserve its current behaviour.