Skip to content

Import Reader and Transit Services; Harden Release Packaging and CodeQL Validation - #256

Merged
enteriaza merged 4 commits into
masterfrom
NNTPD-Import
Oct 29, 2026
Merged

enteriaza merged 4 commits into
masterfrom
NNTPD-Import

Conversation

@enteriaza

Copy link
Copy Markdown
Collaborator

Description

Summary

Import the ReaderService and TransitService projects and their associated test suites into VectorNNTPD, preserving the existing service architecture while strengthening release packaging, CI validation, and CodeQL analysis coverage.

Changes

  • Service integration

    • Import ReaderService and TransitService, including their test projects.
    • Preserve the shared Common architecture and separation between services.
    • Keep the solution free of the removed NNTP server project and avoid introducing service-to-service dependencies.
  • Release packaging and deployment

    • Package BackFiller, Storage, Reader, and Transit services independently.
    • Update release scripts and validation for Windows and Linux packages.
    • Align systemd units, environment examples, and deployment documentation with the current package layout.
    • Update packaging contract tests to match current release validation behaviour.
  • CodeQL and code quality

    • Ensure CodeQL performs non-incremental extraction so all relevant source and test files are included in analysis.
    • Address identified CodeQL findings across production and test code.
    • Improve test resource disposal, exception handling, path operations, and other code-quality issues.
    • Retain narrowly scoped suppressions where findings are intentionally accepted rather than removing suppressions indiscriminately.
  • Test reliability

    • Isolate profiler tests from ambient global state to prevent test-order and concurrency-related failures.
    • Preserve the existing mutable ArticleTransferWindow.Window behaviour.

Verification

Local Release verification completed successfully:

  • Release solution build: Passed — 0 warnings, 0 errors.
  • Common.Tests: 1,191 passed.
  • StorageService.Tests: 520 passed.
  • BackFillerService.Tests: 1,732 passed.
  • ReaderService.Tests: 3,742 passed, 118 skipped.
  • TransitService.Tests: 3,013 passed, 18 skipped.
  • CodeQL: Analysis completed successfully against the final local source state. No unsuppressed findings were identified outside generated bin/obj output.

Outstanding validation

GitHub-hosted CodeQL analysis and required PR checks have not yet been verified. They must be confirmed after the branch is pushed and the PR is opened.

Risk and compatibility notes

  • The existing Reader/Transit role separation is preserved.
  • Existing justified CodeQL suppressions remain in place.
  • The mutable ArticleTransferWindow.Window property is intentionally unchanged to preserve its current behaviour.

…tion**

- Import ReaderService and TransitService with corresponding test projects.
- Preserve service separation and shared Common architecture.
- Package BackFiller, Storage, Reader, and Transit independently for Windows and Linux.
- Update release scripts, CI workflows, systemd units, and deployment documentation.
- Fix CodeQL findings across production and test code.
- Ensure CodeQL performs non-incremental extraction to include all source files.
- Correct test resource disposal, exception handling, path operations, and code-quality issues.
- Fix profiler test isolation and packaging-contract assertions.
- Verify all five test suites and the Release solution build.
@enteriaza enteriaza self-assigned this Oct 29, 2026
@enteriaza enteriaza added the enhancement New feature or request label Oct 29, 2026

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@enteriaza
enteriaza merged commit d0c2f10 into master Oct 29, 2026
7 checks passed
@enteriaza
enteriaza deleted the NNTPD-Import branch October 29, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants